Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2033/verify-nypl-header-links #508

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

ayan1229
Copy link
Contributor

Jira Ticket

This PR does the following:

  • verifies the external NYPL app links nested inside DRB app
  • verifies when clicked on the links user is directed to the correct landing pages.

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 2:01am

And the <landing page header> should be displayed

Examples:
| first header link | landing page header |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with cucumber syntax. Does it always start with a row without double quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Toxiapo yes. First row will always be without quotes to map the next rows with the main steps

@ayan1229 ayan1229 merged commit 1da12b2 into development Jul 12, 2024
7 checks passed
@ayan1229 ayan1229 deleted the SFR-2033/verify-header-links branch July 12, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants