Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-1945: Fix Playwright tests #495

Merged
merged 5 commits into from
Apr 9, 2024
Merged

SFR-1945: Fix Playwright tests #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
177ba7b
Revert "Update locations header link locator"
clarissarichard Apr 8, 2024
a5e381a
Merge branch 'development' of github.com:NYPL/sfr-bookfinder-front-en…
clarissarichard Apr 8, 2024
29fa097
Updated locations header link locator
clarissarichard Apr 8, 2024
0c69bba
Updated changelog
clarissarichard Apr 8, 2024
1c1abae
Corrected lint error
clarissarichard Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- SFR-1917: Fixed failing Playwright tests
- Add APP_ENV build arg in yml file and Dockerfile
- Update Github Action for release from create-release to action-gh-release
- SFR-1945: Fixed more failing Playwright tests

## [0.18.0]

Expand Down
3 changes: 2 additions & 1 deletion playwright/support/mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ export const elements = {
"catalog header link": "span:text('Go To The Catalog')",
"research catalog header link": "span:text('Go To The Research Catalog')",
"close my account header link": "[aria-label='Close']",
"locations header link": "[href='https://www.nypl.org/locations']",
"locations header link":
"[href='https://www.nypl.org/locations']:text('Locations')",
"library card header link": "[href='https://www.nypl.org/library-card/new']",
"email updates header link":
"[href='https://pub.email.nypl.org/subscriptioncenter']",
Expand Down
Loading