Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-1897: Add Playwright integration tests #487

Merged
merged 17 commits into from
Aug 22, 2024
Merged

SFR-1897: Add Playwright integration tests #487

merged 17 commits into from
Aug 22, 2024

Conversation

jackiequach
Copy link
Collaborator

@jackiequach jackiequach commented Mar 19, 2024 •
edited
Loading

Jira Ticket

This PR does the following:

  • Setup Playwright configuration for integration tests
  • Add integration tests for downloading limited access books
  • Update CI.yml to include Playwright integration tests and update action versions
  • Update Dockerfile to follow Next.js example and copy next.config.js to ignore msw during build

Testing requirements & instructions:

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 5:44pm

@jackiequach jackiequach changed the title [WIP] SFR-1897: Add Playwright integration tests SFR-1897: Add Playwright integration tests Aug 14, 2024
@jackiequach jackiequach marked this pull request as ready for review August 15, 2024 14:51
kylevillegas93
kylevillegas93 reviewed Aug 15, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
kylevillegas93
kylevillegas93 reviewed Aug 15, 2024
View reviewed changes
next.config.js Outdated Show resolved Hide resolved
kylevillegas93
kylevillegas93 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Couple minor non-blocking comments!

@jackiequach jackiequach requested a review from Toxiapo August 21, 2024 17:45
@jackiequach jackiequach merged commit 240fab0 into development Aug 22, 2024
8 checks passed
@jackiequach jackiequach deleted the SFR-1897_add_playwright_integration_tests branch August 22, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylevillegas93 kylevillegas93 kylevillegas93 approved these changes

@Toxiapo Toxiapo Toxiapo approved these changes

@samanthaandrews samanthaandrews Awaiting requested review from samanthaandrews samanthaandrews is a code owner

@kristojorg kristojorg Awaiting requested review from kristojorg

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackiequach @Toxiapo @kylevillegas93