Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-1869: Add assertion step to Playwright test #474

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

clarissarichard
Copy link
Contributor

@clarissarichard clarissarichard commented Jan 3, 2024

Jira Ticket

This PR does the following:

  • Adds assertion step to edd.feature that confirms a button exists before attempting to click it

Testing requirements & instructions:

  • Run Playwright tests and all tests pass

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 6:03pm

@clarissarichard clarissarichard marked this pull request as draft January 3, 2024 18:03
@samanthaandrews
Copy link
Contributor

hey @clarissarichard is this ready for review? i saw that it is still in "draft" state. lmk and Jackie or I will take a look!

@clarissarichard clarissarichard marked this pull request as ready for review January 3, 2024 21:31
@clarissarichard
Copy link
Contributor Author

@samanthaandrews and @jackiequach - yes, this is ready for your review! Just needed to make sure the other tests still passed.

@clarissarichard clarissarichard merged commit 5bac958 into development Jan 4, 2024
7 checks passed
@clarissarichard clarissarichard deleted the SFR-1869/add-assertion-step branch January 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants