Merge pull request #404 from NYPL/development

Release 0.17.0 to production

.github/workflows/build-production.yaml

@@ -47,12 +47,11 @@ jobs:
       - name: checkout
         uses: actions/checkout@v2
 
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
-
-      - name: Set up node with version from nvm
+      - name: Setup Node
         uses: actions/setup-node@v2
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+        with:
+          node-version-file: ".nvmrc"
+          cache: npm
 
       - name: Configure AWS credentials from Test account
         uses: aws-actions/configure-aws-credentials@v1

.github/workflows/build-qa.yml

@@ -15,12 +15,11 @@ jobs:
       - name: checkout
         uses: actions/checkout@v2
 
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
-
-      - name: Set up node with version from nvm
+      - name: Setup Node
         uses: actions/setup-node@v2
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+        with:
+          node-version-file: ".nvmrc"
+          cache: npm
 
       - name: Configure AWS credentials from Test account
         uses: aws-actions/configure-aws-credentials@v1

.github/workflows/ci.yml

@@ -30,12 +30,12 @@ jobs:
       CI: true
     steps:
       - uses: actions/checkout@v2
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
 
-      - name: Use Node Version from nvmrc
-        uses: actions/setup-node@v1
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version-file: ".nvmrc"
+          cache: npm
 
       - name: Cache node modules
         uses: actions/cache@v2
@@ -51,7 +51,7 @@ jobs:
             ${{ runner.os }}-
 
       - name: Install Dependencies
-        run: npm run install:ci
+        run: npm ci
 
       - name: Lint
         run: npm run lint
@@ -63,12 +63,12 @@ jobs:
       CI: true
     steps:
       - uses: actions/checkout@v2
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
 
-      - name: Use Node Version from nvmrc
-        uses: actions/setup-node@v1
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version-file: ".nvmrc"
+          cache: npm
 
       - name: Cache node modules
         uses: actions/cache@v2
@@ -84,7 +84,7 @@ jobs:
             ${{ runner.os }}-
 
       - name: Install Dependencies
-        run: npm run install:ci
+        run: npm ci
 
       - name: Typecheck
         run: node_modules/typescript/bin/tsc --noEmit
@@ -96,12 +96,12 @@ jobs:
       CI: true
     steps:
       - uses: actions/checkout@v2
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
 
-      - name: Use Node Version from nvmrc
-        uses: actions/setup-node@v1
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version-file: ".nvmrc"
+          cache: npm
 
       - name: Cache node modules
         uses: actions/cache@v2
@@ -117,7 +117,7 @@ jobs:
             ${{ runner.os }}-
 
       - name: Install Dependencies
-        run: npm run install:ci
+        run: npm ci
 
       - name: Test
         run: npm run test
@@ -126,17 +126,12 @@ jobs:
     # Don't push anything to ECR, just build the docker image to make sure there are no build failures
     name: Build Docker Image
     runs-on: ubuntu-latest
+    env:
+      CI: true
     steps:
       - name: checkout
         uses: actions/checkout@v2
 
-      - id: nvmrc
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
-
-      - name: Set up node with version from nvm
-        uses: actions/setup-node@v2
-        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
-
       - name: Build image
         env:
           AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY }}

.gitignore

@@ -20,4 +20,7 @@ vega.feature
 vega.spec.ts
 
 # New Relic
-newrelic_agent.log
+newrelic_agent.log
+
+.vscode
+.vscode/launch.json

.nvmrc

@@ -1 +1 @@
-v16.13.0
+v16.19.0

CHANGELOG.md

@@ -1,5 +1,18 @@
 # CHANGE LOG
 
+## [0.17.0]
+- Replace Search Examples with Recently Added Collections to landing page
+- Add primary hero to the landing page
+- Add Part of Collection to Edition/Work pages
+- Add Collection page
+- Add collection placeholder image
+- Update hero image to update based on screen size
+- Chore: fresh package-lock.json install and fix install errors on mac with M1 chip
+- Add Playwright/Cucumber tests to support new Recently Added Collections feature on landing page
+- Chore: fresh package-lock.json install and fix install errors on mac with M1 chip
+- Add Playwright/Cucumber tests to support new Recently Added Collections feature on landing page
+- Refactored Playwright/Cucumber tests to use new page visit actions function
+
 ## [0.16.1]
 
 - add features and tests for publication year filter

Dockerfile

@@ -26,7 +26,7 @@ ENV NEW_RELIC_APP_NAME $NEW_RELIC_APP_NAME
 
 # Install dependencies.
 COPY package.json package-lock.json ./
-RUN npm run install:ci
+RUN npm ci --cache .npm
 
 # Copy the app files.
 COPY . ./

config/appConfig.ts

@@ -17,6 +17,7 @@ export default {
     editionPath: "/edition",
     readPath: "/link",
     languagesPath: "/utils/languages",
+    collectionPath: "/collection",
   },
   booksCount: {
     apiUrl: "/utils/counts",

cucumber.json

@@ -0,0 +1,9 @@
+{
+  "default": {
+    "import": ["playwright/tests/**/*.ts", "playwright/support/**/*.ts"],
+    "worldParameters": {
+      "appUrl": "https://drb-qa.nypl.org",
+      "headless": false
+    }
+  }
+}