Skip to content

Commit

Permalink
Merge branch 'development' into SFR-1792_node_18
Browse files Browse the repository at this point in the history
  • Loading branch information
jackiequach committed Nov 29, 2023
2 parents 26800be + a64a7b8 commit c8afaf0
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 21 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Each line is a file pattern followed by one or more owners. These owners will be the default owners for everything in the repo. Unless a later match takes precedence,e ach owner will be requested for review when someone opens a pull request.
* @samanthaandrews @jackiequach
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- Upgrade newrelic to v11.5.0
- Upgrade Next.js to v13.5.6
- Upgrade to Node 18
- Chore: Add Jackie and Sam as codeowners
- Fix: SFR-1839- pw automated test fix / update the login credentials

## [0.17.5]

Expand Down
9 changes: 0 additions & 9 deletions playwright/features/pub_yearFilter.feature
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,3 @@ Feature: Publication Year Filter
And I fill in the "publication year to filter" with "1900"
And I click the "publication year apply button"
Then the "first search result edition" should be displayed

Scenario: As a user I filter by publication years and verify the search results
Given I go to the "home" page
When I fill in the "homepage search box" with "Jane Austen"
And I click the "search button"
And I fill in the "publication year from filter" with "1800"
And I fill in the "publication year to filter" with "1835"
And I click the "publication year apply button"
Then only editions published between year "1800" and "1835" should be displayed
3 changes: 1 addition & 2 deletions playwright/support/mappings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ export const elements = {
"Russian language subheader": "span:text('Russian')",
"first search result subject": "a:text('Petroleum')",
"first search result title": "a:text('IBM 1401') >> nth=0",
"first search result author":
"span:text('By') > a:text('Corelli, Marie') >> nth=0",
"first search result author": "a:text('Corelli, Marie') >> nth=0",
"first search result keyword": "a:text('IBM 1401') >> nth=0",
"government documents checkbox":
"span:text('Show only US government documents')",
Expand Down
10 changes: 0 additions & 10 deletions playwright/tests/assertions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,3 @@ Then(
return expect(this.page.locator(element).isChecked()).toBeTruthy();
}
);

Then(
/^only editions published between year "([^"]*)" and "([^"]*)" should be displayed$/,
async function (this: CustomWorld, elementKey: keyof typeof elements) {
const element = elements[elementKey];
return expect(this.page.locator(element)).toBeVisible({
timeout: 50000,
});
}
);

0 comments on commit c8afaf0

Please sign in to comment.