Skip to content

Commit

Permalink
Merge pull request #439 from NYPL/development
Browse files Browse the repository at this point in the history
Release 0.17.4 to production
  • Loading branch information
jackiequach authored Sep 11, 2023
2 parents ce8b857 + 1a4af59 commit ba23acb
Show file tree
Hide file tree
Showing 24 changed files with 2,371 additions and 289 deletions.
49 changes: 49 additions & 0 deletions .github/workflows/Playwright.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Playwright Tests for Digital Research Books

on:
schedule:
- cron: "00 14 * * 1-5"
pull_request:
branches: [production]
types: [opened, synchronize, reopened]


jobs:
tests:
name: Run Tests
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3

- uses: actions/setup-node@v2
with:
node-version-file: ".nvmrc"

- name: Install Deps
run: npm i @cucumber/[email protected] @playwright/[email protected]

- name: Install Playwright Browser Utils
run: npx playwright install --with-deps

- name: Set the world parameters as an env var
run: |
echo "WORLD_PARAMETERS={\"appUrl\": \"https://digital-research-books-beta.nypl.org\", \"headless\": true}" >> $GITHUB_ENV
- name: Run Cucumber tests
run: npm run cucumber -- playwright/features --world-parameters '${{ env.WORLD_PARAMETERS }}'
env:
"catalog username": ${{ secrets.CATALOG_USERNAME }}
"catalog password": ${{ secrets.CATALOG_USER_PIN }}
CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
CUCUMBER_PUBLISH_ENABLED: true

- name: Slack Notification
if: ${{ always() }}
uses: rtCamp/action-slack-notify@v2
env:
SLACK_CHANNEL: test_reports
SLACK_MESSAGE: https://reports.cucumber.io/report-collections/01dbd6e8-653b-4597-b901-6caf2e653b07
SLACK_TITLE: DRB Cucumber/Playwright Test Results
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_USERNAME: nyplorgBot
4 changes: 2 additions & 2 deletions .github/workflows/build-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ jobs:
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-672b7e7f98ee.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:production-latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:production-latest
- name: Force ECS Update
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-bf8436264b01-development.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:qa-latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:qa-latest
- name: Force ECS Update
run: |
Expand Down
41 changes: 0 additions & 41 deletions .github/workflows/rspec-integration-tests.yml

This file was deleted.

24 changes: 18 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# CHANGE LOG

- Update production and qa builds to use unique ECR image tag

## [0.17.4]

- Add id as subsection for "Read Online" CTA analytics tracking
- Add: SFR-1743: Verify advance search filters for DRB
- Add: SFR-1746: Verify "read online only" toggle button on item details page
- Add: SFR-1748: Verify the headers and footers of Advanced Search page
- Add: SFR-1749: Verify the footers and the respecting landing pages (homepage)
- Add: SFR-1751: Verify the Back to Search Results button is available on Item Details page
- Add: SFR-1750: Verify the header links of home page
- Add: SFR-1745: Add Playwright tests to GitHub Actions
- Fix: SFR-1755: Fix Playwright test failures
- Upgrade New Relic packages and update configuration
- Update Adobe Analytics page names
- SFR-1778: Fix failing Playwright tests
- SFR-1752: Remove rspec workflow

## [0.17.3]

- Upgrade to Next 13.4.7
Expand Down Expand Up @@ -36,12 +54,6 @@

## [0.16.1]

- add features and tests for publication year filter
- add features and tests for language filter
- Upgrade dgx-header-component to v2.8.0-r16-rc-3

## [0.16.0]

- add features and tests for government docs filter
- Add github actions to automate tag and release
- Replace DS Header component with dgx-header-component v2.8.0-r16-rc-2
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,7 @@ Term combinations
### Test

To run unit tests, run `npm run test` in the terminal.

### Deprecated

As of September 2023, the [rspec-integration-tests.yml](https://github.com/NYPL/sfr-bookfinder-front-end/actions/workflows/rspec-integration-tests.yml) workflow is no longer in use and has been replaced by the [Playwright.yml](https://github.com/NYPL/sfr-bookfinder-front-end/blob/development/.github/workflows/Playwright.yml) workflow. Please contact the DRB team in Digital for more information.
Loading

0 comments on commit ba23acb

Please sign in to comment.