SFR-1080 Properly handle repo secrets in actions

NYPL · May 13, 2021 · 9256440 · 9256440
1 parent 18ea831
commit 9256440
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/build-branch-qa.yaml b/.github/workflows/build-branch-qa.yaml
@@ -30,8 +30,9 @@ jobs:
           ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
           ECR_REPOSITORY: sfr_ingest_pipeline
           BRANCH_NAME: ${{ github.head_ref }}
+          AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY}}
         run: |
-          docker build --build-arg airtable-api-key=${{ secrets.AIRTABLE_API_KEY }} -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
+          docker build --build-arg airtable-api-key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME
           echo "::set-output name=image::$ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME"
 

diff --git a/.github/workflows/build-qa.yml b/.github/workflows/build-qa.yml
@@ -38,8 +38,9 @@ jobs:
           ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
           ECR_REPOSITORY: sfr-front-end
           IMAGE_TAG: ${{ github.sha }}
+          AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY }}
         run: |
-          docker build --build-arg airtable-api-key=${{ secrets.AIRTABLE_API_KEY }} -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
+          docker build --build-arg airtable-api-key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
           docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest