Merge branch 'github-actions' of https://github.com/NYPL/sfr-bookfind…

…er-front-end into github-actions
NYPL · Mar 9, 2021 · 872100c · 872100c
2 parents 699094f + e02ced1
commit 872100c
Show file tree

Hide file tree

Showing 10 changed files with 134 additions and 89 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,122 @@
+# For all PRs, this workflow will
+#     - Install deps
+#     - Lint
+#     - Typecheck
+#     - Test
+name: CI
+
+on:
+  # will run on all PRs that are opened or updated (synchronized)
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  # changelog must be edited for every PR
+  changelog:
+    name: Updates Changelog
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: dangoslen/[email protected]
+        with:
+          changeLogPath: "CHANGELOG.md"
+          skipLabel: "no-changelog"
+
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    env:
+      CI: true
+    steps:
+      - uses: actions/checkout@v2
+      - id: nvmrc
+        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
+
+      - name: Use Node Version from nvmrc
+        uses: actions/setup-node@v1
+        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+
+      - name: Cache node modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
+        with:
+          # npm cache files are stored in `~/.npm` on Linux/macOS
+          path: ~/.npm
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+
+      - name: Install Dependencies
+        run: npm install
+
+      - name: Lint
+        run: npm run lint
+
+  typecheck:
+    name: Typecheck
+    runs-on: ubuntu-latest
+    env:
+      CI: true
+    steps:
+      - uses: actions/checkout@v2
+      - id: nvmrc
+        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
+
+      - name: Use Node Version from nvmrc
+        uses: actions/setup-node@v1
+        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+
+      - name: Cache node modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
+        with:
+          # npm cache files are stored in `~/.npm` on Linux/macOS
+          path: ~/.npm
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+
+      - name: Install Dependencies
+        run: npm install
+
+      - name: Typecheck
+        run: node_modules/typescript/bin/tsc --noEmit
+
+  test:
+    name: Test & Coverage
+    runs-on: ubuntu-latest
+    env:
+      CI: true
+    steps:
+      - uses: actions/checkout@v2
+      - id: nvmrc
+        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
+
+      - name: Use Node Version from nvmrc
+        uses: actions/setup-node@v1
+        with: { node-version: "${{ steps.nvmrc.outputs.NODE_VERSION }}" }
+
+      - name: Cache node modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
+        with:
+          # npm cache files are stored in `~/.npm` on Linux/macOS
+          path: ~/.npm
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+
+      - name: Install Dependencies
+        run: npm install
+
+      - name: Test
+        run: npm run test
diff --git a/.nycrc b/.nycrc
diff --git a/.storybook/addons.js b/.storybook/addons.js
diff --git a/.storybook/config.js b/.storybook/config.js
diff --git a/.storybook/webpack.config.js b/.storybook/webpack.config.js
diff --git a/.travis.yml b/.travis.yml
diff --git a/AWSCLIV2.pkg b/AWSCLIV2.pkg
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,7 @@
 # CHANGE LOG
+## PRERELEASE
+- Refactors app to use NextJS, NYPL Design System, Typescript
+
 ## [0.9.3] 
 - Updated dgx-global-footer to 0.5.7.
 - Adds the new urlType prop to the Footer component set to "absolute"

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -4,10 +4,8 @@
   "private": true,
   "scripts": {
     "dev": "next dev",
-    "eb-dev": "next dev -p $PORT",
     "build": "next build",
     "start": "next start",
-    "eb-start": "NODE_ENV=development next build && node ./server.js",
     "test": "jest",
     "test:watch": "jest --watch",
     "lint": "eslint --ignore-path .gitignore '*/**/*.{ts,tsx}'",
@@ -24,7 +22,10 @@
     "react": "^16.14.0",
     "react-dom": "^16.14.0",
     "redux": "4.0.1",
-    "sass": "^1.29.0"
+    "sass": "^1.29.0",
+    "typescript": "^4.1.3",
+    "@types/node": "^14.14.33",
+    "@types/react": "^16.9.5"
   },
   "devDependencies": {
     "@testing-library/jest-dom": "^5.11.9",
@@ -33,7 +34,6 @@
     "@types/enzyme-adapter-react-16": "^1.0.6",
     "@types/jest": "^26.0.20",
     "@types/mocha": "^8.2.0",
-    "@types/react": "^16.9.5",
     "@types/testing-library__jest-dom": "^5.9.5",
     "@typescript-eslint/eslint-plugin": "^4.10.0",
     "@typescript-eslint/parser": "^4.10.0",
@@ -52,7 +52,6 @@
     "eslint-plugin-react-hooks": "^4.2.0",
     "jest": "^26.6.3",
     "next-page-tester": "^0.23.0",
-    "prettier": "^2.2.1",
-    "typescript": "^4.1.3"
+    "prettier": "^2.2.1"
   }
 }