Skip to content

Commit

Permalink
Merge pull request #446 from NYPL/SFR-1721_fix_issues_from_qa
Browse files Browse the repository at this point in the history 
SFR-1721: Fix issues from QA
  • Loading branch information
@jackiequach
jackiequach authored Sep 29, 2023
2 parents 02757ca + ee6dbd3 commit 7cc523c
Show file tree
Hide file tree
Showing 13 changed files with 1,122 additions and 1,158 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- Fix: Small adjustments to Playwright tests
- Upgrade testing-library packages to v14 and jest to v29
- Remove TemplateFooter components
- Replace Template components with custom DrbTemplate component to reduce repeat components
- Replace Template components with TemplateAppContainer and DrbBreakout to reduce repeat components
- Upgrade to NYPL Design System 1.7.3
- Replace fireEvent with userEvent

Expand Down
201 changes: 102 additions & 99 deletions src/components/About/About.tsx
View file
Original file line number Diff line number Diff line change
@@ -1,115 +1,118 @@
import React from "react";
import { Heading } from "@nypl/design-system-react-components";
import {
Heading,
TemplateAppContainer,
} from "@nypl/design-system-react-components";
import Link from "../Link/Link";
import DrbTemplate, {
DrbBreakout,
DrbContent,
DrbContentPrimary,
} from "../DrbTemplate/DrbTemplate";
import DrbBreakout from "../DrbBreakout/DrbBreakout";

const About: React.FC = () => {
return (
<DrbTemplate>
<DrbBreakout breadcrumbsData={[{ url: "/about", text: "About" }]} />
<DrbContent>
<DrbContentPrimary>
<Heading level="one">
<span>
<span className="rn-section-title__emphasis">
Digital Research Books
</span>{" "}
Beta
</span>
</Heading>
const breakoutElement = (
<DrbBreakout breadcrumbsData={[{ url: "/about", text: "About" }]} />
);

const contentPrimaryElement = (
<>
<Heading level="one">
<span>
<span className="rn-section-title__emphasis">
Digital Research Books
</span>{" "}
Beta
</span>
</Heading>

<p>
Digital Research Books Beta is an experimental project, now in early
Beta testing, that collects digital versions of research books from
many different sources, including Open Access publications, into one
convenient place to search.
</p>
<p>
Digital Research Books Beta is an experimental project, now in early
Beta testing, that collects digital versions of research books from many
different sources, including Open Access publications, into one
convenient place to search.
</p>

<p>
All the materials in Digital Research Books Beta are completely free
to read and most of them you can download and keep, with no library
card required. The books are either in the{" "}
<Link to="/license">public domain</Link>, with no restrictions on
your use of them, or under{" "}
<Link to="/license">Creative Commons licences</Link> that may have
some conditions, but only on redistribution or adaptation.
</p>
<p>
All the materials in Digital Research Books Beta are completely free to
read and most of them you can download and keep, with no library card
required. The books are either in the{" "}
<Link to="/license">public domain</Link>, with no restrictions on your
use of them, or under{" "}
<Link to="/license">Creative Commons licences</Link> that may have some
conditions, but only on redistribution or adaptation.
</p>

<p>
In addition to collecting these digital editions, we group all the
editions of the same title together as a single “work.” For instance
there are many editions of{" "}
<Link to="/work/e34d73df-f32b-49e1-8fdf-151db2a7806a">
Mary Wollstonecraft’s A Vindication of the Rights of Woman
</Link>
, many of them available digitally. We group them all together under
a single search result and try to make the differences between
them--years when and places where they were published, for
instance--easy to understand.
</p>
<p>
In addition to collecting these digital editions, we group all the
editions of the same title together as a single “work.” For instance
there are many editions of{" "}
<Link to="/work/e34d73df-f32b-49e1-8fdf-151db2a7806a">
Mary Wollstonecraft’s A Vindication of the Rights of Woman
</Link>
, many of them available digitally. We group them all together under a
single search result and try to make the differences between them--years
when and places where they were published, for instance--easy to
understand.
</p>

<Heading
level="two"
id="sources-and-data-heading"
text="Sources and Data"
/>
<Heading
level="two"
id="sources-and-data-heading"
text="Sources and Data"
/>

<p>
The material in Digital Research Books Beta are drawn from several
public sources, mainly{" "}
<Link to="https://www.hathitrust.org/">HathiTrust</Link>,{" "}
<Link to="https://doabooks.org/">
The Directory of Open Access Books
</Link>
, and <Link to="http://www.gutenberg.org/">Project Gutenberg</Link>.
We are continuously adding more books from these and other sources.
We then cross-reference them with library records from NYPL and{" "}
<Link to="https://www.worldcat.org/">WorldCat</Link>, using OCLC’s
experimental{" "}
<Link to="http://classify.oclc.org/classify2/">Classify</Link> to
make connections between different editions of the same work.
</p>
<p>
The material in Digital Research Books Beta are drawn from several
public sources, mainly{" "}
<Link to="https://www.hathitrust.org/">HathiTrust</Link>,{" "}
<Link to="https://doabooks.org/">
The Directory of Open Access Books
</Link>
, and <Link to="http://www.gutenberg.org/">Project Gutenberg</Link>. We
are continuously adding more books from these and other sources. We then
cross-reference them with library records from NYPL and{" "}
<Link to="https://www.worldcat.org/">WorldCat</Link>, using OCLC’s
experimental{" "}
<Link to="http://classify.oclc.org/classify2/">Classify</Link> to make
connections between different editions of the same work.
</p>

<Heading
level="two"
id="beta-testing-heading"
text="What does Beta Testing mean?"
/>
<Heading
level="two"
id="beta-testing-heading"
text="What does Beta Testing mean?"
/>

<p>
It means that this is a work-in-progress. We are constantly working
on the interface and trying new ideas to deal with the data. If you
visit repeatedly, sometimes it may look different. If you search for
the same thing often, the results may change--hopefully for the
better as we refine how the search works. There may be errors. The
cross-referencing is automated and based on millions of library
records including some that are inaccurate. Part of what we are
exploring is how to detect and adjust mistakes, and how to make sure
we don’t introduce any new ones.
</p>
<p>
It means that this is a work-in-progress. We are constantly working on
the interface and trying new ideas to deal with the data. If you visit
repeatedly, sometimes it may look different. If you search for the same
thing often, the results may change--hopefully for the better as we
refine how the search works. There may be errors. The cross-referencing
is automated and based on millions of library records including some
that are inaccurate. Part of what we are exploring is how to detect and
adjust mistakes, and how to make sure we don’t introduce any new ones.
</p>

<p>
It also means that the project may change radically. We may change
the URL. We may learn that a different approach is necessary. We may
learn that it isn’t useful enough to anyone to continue. If you find
books in Digital Research Books Beta that are especially useful to
you, you should download a copy so that you have one no matter what
becomes of this project.
</p>
<p>
It also means that the project may change radically. We may change the
URL. We may learn that a different approach is necessary. We may learn
that it isn’t useful enough to anyone to continue. If you find books in
Digital Research Books Beta that are especially useful to you, you
should download a copy so that you have one no matter what becomes of
this project.
</p>

<p>
Most of all, it means your feedback is important! Most pages have a
feedback button in the bottom right corner. We want to know what you
think. If there are things you like or dislike, if there’s a feature
missing, if you find an error please tell us in the feedback!
</p>
</DrbContentPrimary>
</DrbContent>
</DrbTemplate>
<p>
Most of all, it means your feedback is important! Most pages have a
feedback button in the bottom right corner. We want to know what you
think. If there are things you like or dislike, if there’s a feature
missing, if you find an error please tell us in the feedback!
</p>
</>
);
return (
<TemplateAppContainer
breakout={breakoutElement}
contentPrimary={contentPrimaryElement}
/>
);
};

Expand Down
Loading

1 comment on commit 7cc523c

@vercel
Copy link

@vercel vercel bot commented on 7cc523c Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

sfr-bookfinder-front-end – ./

sfr-bookfinder-front-end-git-development-nypl.vercel.app
sfr-bookfinder-front-end-nypl.vercel.app
sfr-bookfinder-front-end.vercel.app

Please sign in to comment.