Skip to content

Commit

Permalink
SFR-1080 Replace dash in api key variable with underscore
Browse files Browse the repository at this point in the history
  • Loading branch information
mwbenowitz committed May 13, 2021
1 parent a042cc6 commit 60130ef
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-branch-qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
BRANCH_NAME: ${{ github.head_ref }}
AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY}}
run: |
docker build --build-arg airtable-api-key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
docker build --build-arg airtable_api_key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME
echo "::set-output name=image::$ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
IMAGE_TAG: ${{ github.sha }}
AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY }}
run: |
docker build --build-arg airtable-api-key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
docker build --build-arg airtable_api_key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$BRANCH_NAME .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ RUN apk add git

WORKDIR /

ARG airtable-api-key
ARG airtable_api_key

# Set environment variables. NODE_ENV is set early because we
# want to use it when running `npm install` and `npm run build`.
ENV PATH /app/node_modules/.bin:$PATH
ENV PORT=3000 \
NODE_ENV=production
ENV NEXT_PUBLIC_AIRTABLE_API_KEY $airtable-api-key
ENV NEXT_PUBLIC_AIRTABLE_API_KEY $airtable_api_key

# Install dependencies.
COPY package.json ./
Expand Down

0 comments on commit 60130ef

Please sign in to comment.