Skip to content

Commit

Permalink
replace secrets with inline values
Browse files Browse the repository at this point in the history
  • Loading branch information
jackiequach committed Jun 15, 2023
1 parent 910ae8d commit 58bc47c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,11 @@ jobs:
IMAGE_TAG: ${{ github.sha }}
AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY }}
NEW_RELIC_LICENSE_KEY: ${{ secrets.NEW_RELIC_LICENSE_KEY }}
NEXT_PUBLIC_ADOBE_ANALYTICS: ${{ secrets.NEXT_PUBLIC_ADOBE_ANALYTICS }}
run: |
docker build --build-arg airtable_api_key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG \
--build-arg NEW_RELIC_APP_NAME="Digital Research Books (PROD)" \
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS=$NEXT_PUBLIC_ADOBE_ANALYTICS .
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-672b7e7f98ee.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@ jobs:
IMAGE_TAG: ${{ github.sha }}
AIRTABLE_KEY: ${{ secrets.AIRTABLE_API_KEY }}
NEW_RELIC_LICENSE_KEY: ${{ secrets.NEW_RELIC_LICENSE_KEY }}
NEXT_PUBLIC_ADOBE_ANALYTICS: ${{ secrets.NEXT_PUBLIC_ADOBE_ANALYTICS }}
run: |
docker build --build-arg airtable_api_key=$AIRTABLE_KEY -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG \
--build-arg NEW_RELIC_APP_NAME="Digital Research Books (QA)" \
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS=$NEXT_PUBLIC_ADOBE_ANALYTICS .
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-bf8436264b01-development.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
Expand Down

0 comments on commit 58bc47c

Please sign in to comment.