Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCC-4380 - Hold page VQA fixes #417

Merged
merged 3 commits into from
Dec 12, 2024
Merged

SCC-4380 - Hold page VQA fixes #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9b458a
Small vqa fixes
dgcohen Dec 11, 2024
e7cc403
Add There was a problem prefix
dgcohen Dec 12, 2024
a94fe3d
Merge in hold pages
dgcohen Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/HoldPages/CopyrightRestrictionsBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const CopyrightRestrictionsBanner = () => {
type="neutral"
heading="Copyright restrictions"
content={
<Box>
<Box mt="xs">
<Text>
The copyright law of the United States (Title 17, United States
Code) governs the making of photocopies or other reproductions of
Expand Down
6 changes: 3 additions & 3 deletions src/components/HoldPages/EDDRequestForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const EDDRequestForm = ({
value={eddFormState.source}
/>
<Box>
<Heading level="h3" size="heading4" mb="m">
<Heading level="h3" size="heading4" mb="s">
Required information
</Heading>
<Text noSpace>
Expand Down Expand Up @@ -197,8 +197,8 @@ const EDDRequestForm = ({
ref={validatedInputRefs["chapterTitle"]}
/>
</FormField>
<Box>
<Heading level="h3" size="heading4" mb="xs">
<Box mt="xs">
<Heading level="h3" size="heading4" mb="s">
Optional information
</Heading>
<Text noSpace>
Expand Down
13 changes: 8 additions & 5 deletions src/components/HoldPages/HoldConfirmationAccordionData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
</Text>
<Text noSpace>
The item will be listed as &quot;Ready for pickup&quot; under your
holds tab when it is available. You will receive an email confirmation
after your item has arrived.
requests tab when it is available. You will receive an email
confirmation after your item has arrived.
</Text>
</>
),
Expand Down Expand Up @@ -79,12 +79,15 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
</ExternalLink>{" "}
or call 917-ASK-NYPL (
<ExternalLink href="tel:19172756975">917-275-6975</ExternalLink>).
Processed requests can also be canceled from the holds tab in your
Processed requests can also be canceled from the requests tab in your
patron account.
</Text>
<Text noSpace>
For more information about our requesting services, please see
Requesting Research Materials.
For more information about our requesting services, please see{" "}
<ExternalLink href="https://www.nypl.org/research/services/request-materials">
Requesting Research Materials
</ExternalLink>
.
</Text>
</>
),
Expand Down
2 changes: 1 addition & 1 deletion src/components/HoldPages/HoldConfirmationFAQ.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface HoldConfirmationFAQProps {
const HoldConfirmationFAQ = ({ isEDD = false }: HoldConfirmationFAQProps) => {
return (
<Box data-testid={`${isEDD ? "edd" : "on-site"}-confirmation-faq`}>
<Heading level="h3" mb="l">
<Heading level="h3" size="heading4" mb="l">
Frequently asked questions
</Heading>
<Accordion
Expand Down
12 changes: 7 additions & 5 deletions src/config/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,31 +146,33 @@ export const EDD_PAGE_HEADING = "Request scan"
export const EDD_FORM_FIELD_COPY = {
emailAddress: {
label: "Email address",
placeholder: "theresa.smith@gmail.com",
placeholder: "Example: theresasmith@gmail.com",
helperText:
"Your request will be delivered to the email address you enter above.",
invalidText:
"Enter a valid email address. Your request will be delivered to the email address you enter above.",
"There was a problem. Enter a valid email address. Your request will be delivered to the email address you enter above.",
},
startPage: {
label: "Starting page number",
placeholder: "Example: 1",
helperText: "Enter the first page you would like scanned.",
invalidText: "Enter a page number. You may request a maximum of 50 pages.",
invalidText:
"There was a problem. Enter a page number. You may request a maximum of 50 pages.",
},
endPage: {
label: "Ending page number",
placeholder: "Example: 20",
helperText: "Enter the last page you would like scanned.",
invalidText: "Enter a page number. You may request a maximum of 50 pages.",
invalidText:
"There was a problem. Enter a page number. You may request a maximum of 50 pages.",
},
chapterTitle: {
label: "Chapter or article title",
placeholder: "Example: Chapter 1",
helperText:
"Enter the name/number of the chapter or article you would like scanned.",
invalidText:
"Indicate the title of the chapter or article you are requesting.",
"There was a problem. Indicate the title of the chapter or article you are requesting.",
},
author: {
label: "Author",
Expand Down
Loading