Replace ref name and restore parentheses

NYPL · Sep 10, 2024 · 6bdb83a · 6bdb83a
1 parent 677562e
commit 6bdb83a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml
@@ -35,7 +35,7 @@ jobs:
       - name: Build and push Docker image to Amazon ECR
         env:
           ECR_URL: 946183545209.dkr.ecr.us-east-1.amazonaws.com/research-catalog:$APP_ENV-latest
-          MANIFEST: ${aws ecr batch-get-image --repository-name research-catalog --image-ids imageTag="$APP_ENV-latest" --output json | jq --raw-output --join-output '.images[0].imageManifest'}
+          MANIFEST: $(aws ecr batch-get-image --repository-name research-catalog --image-ids imageTag="$APP_ENV-latest" --output json | jq --raw-output --join-output '.images[0].imageManifest')
         run: |
           docker build --build-arg NEXT_PUBLIC_APP_ENV=$APP_ENV --tag $LOCAL_TAG_NAME .
           docker tag $LOCAL_TAG_NAME $ECR_URL

diff --git a/.github/workflows/deploy_qa.yml b/.github/workflows/deploy_qa.yml
@@ -13,7 +13,8 @@ permissions:
 
 env:
   AWS_DEFAULT_REGION: us-east-1
-  LOCAL_TAG_NAME: research-catalog:${{ github.ref_name }}-${{ github.run_number }}
+  # LOCAL_TAG_NAME: research-catalog:${{ github.ref_name }}-${{ github.run_number }}
+  LOCAL_TAG_NAME: research-catalog:test-${{ github.run_number }}
   APP_ENV: qa
 
 jobs:
@@ -36,7 +37,7 @@ jobs:
       - name: Build and push Docker image to Amazon ECR
         env:
           ECR_URL: 946183545209.dkr.ecr.us-east-1.amazonaws.com/research-catalog:$APP_ENV-latest
-          MANIFEST: ${aws ecr batch-get-image --repository-name research-catalog --image-ids imageTag="$APP_ENV-latest" --output json | jq --raw-output --join-output '.images[0].imageManifest'}
+          MANIFEST: $(aws ecr batch-get-image --repository-name research-catalog --image-ids imageTag="$APP_ENV-latest" --output json | jq --raw-output --join-output '.images[0].imageManifest')
 
         run: |
           docker build --build-arg NEXT_PUBLIC_APP_ENV=$APP_ENV --tag $LOCAL_TAG_NAME .