Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add central handling of github 400/500 errors #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add central handling of github 400/500 errors #15

wants to merge 1 commit into from

Conversation

nonword
Copy link
Member

@nonword nonword commented Aug 23, 2017

This PR addresses a gap in upstream error handling:

  • Adds new MappingFileRequestError custom error to report on 5xx status codes from github (as distinct from 4xx errors)
  • Centralize response parsing for locations, patronTypes, and recapCustomerCodes json documents (previously response errors were not translated to custom errors)

@nonword nonword requested a review from nodanaonlyzuul August 23, 2017 14:01
@nodanaonlyzuul
Copy link
Contributor

Hey @nonword - sorry - I've let this PR languish and now it has conflicts that need to be resolved.
Can you resolve the conflicts then Slack me and I'll get right on this.
Thanks and sorrrryyyyyy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodanaonlyzuul nodanaonlyzuul Awaiting requested review from nodanaonlyzuul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonword @nodanaonlyzuul