SCC-4329: rank eval script #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Pass in object so we get a reference to private methods like `buildElasticQuery` | ||
| const resourcesPriv = {} | ||
| require('../lib/resources')({}, resourcesPriv) |
There was a problem hiding this comment.
Should this method be public?
There was a problem hiding this comment.
The whole way that this module attaches itself to the app and exposes public/private methods ought to be changed, but not as part of this work.
charmingduchess
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a "rank eval" script for generating an array of numbers from 0 to 1 that indicate search relevancy performance across a number of target metrics. We'll run this script locally, periodically, as search strategies change to track relevancy performance over time.