QA2: Searchathon fixes #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates: - Add search_scope=journal_title (to ease testing and because it really ought to be implemented in the discovery-api, not the front-end - Match on shelfmark lowercased - Allow smart-quotes in fully-quoted searches - Remove boost=1 on quoted creator/contrib phrase matching - Match on new idIsbn.clean and idIssn.clean (added 2024-10-17) - Updates qa index to 2024-10-16 (added shelfMark.keywordLowercased)
charmingduchess
approved these changes
Oct 18, 2024
| @@ -22,6 +22,10 @@ class ElasticQueryBuilder { | |||
| case 'title': | |||
| this.buildTitleQuery() | |||
| break | |||
| case 'journal_title': | |||
There was a problem hiding this comment.
This is great. Should we ticket the work to remove that transformation from RC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR with several small fixes coming out of the Searchathon session, which are not included in the other mega QA2 PR
Changes:
journal_titleas a search scope, implemented identically to how RC built it - to ease debugging and because it ought to be implemented on the back-endupdatedAtDate(ISO string)