Fix small bug with identifying nypl checkin items

Fix small bug where items generated from holdings record checkin cards failed
to be identiifed as NYPL items. This had no known impact on behavior, but
betrayed the "isItemNyplOwned" function's promise

lib/ownership_determination.js

@@ -1,5 +1,5 @@
 // NYPL item ids start with an 'i'
-const NYPL_ITEM_ID_PATTERN = /^i\d+/
+const NYPL_ITEM_ID_PATTERN = /^i/
 
 const isItemNyplOwned = (item) => {
   return NYPL_ITEM_ID_PATTERN.test(item?.uri)

test/ownership_determination.test.js

@@ -2,7 +2,12 @@ const isItemNyplOwned = require('../lib/ownership_determination').isItemNyplOwne
 
 describe('isItemNyplOwned', function () {
   it('will only return true for certain items', function () {
-    const fakeNyplItems = [{ uri: 'i10022734' }, { uri: 'i123489' }]
+    const fakeNyplItems = [
+      { uri: 'i10022734' },
+      { uri: 'i123489' },
+      // An item generated from a checkin card in a holding has this form:
+      { uri: 'i-h1234-1' }
+    ]
     const fakeColumbiaItems = [{ uri: 'ci10022734' }, { uri: 'ci123489' }]
     const fakePrincetonItems = [{ uri: 'pi10022734' }, { uri: 'pi123489' }]
     const fakeNonsenseItems = [{ uri: 'jsaoisjosjiaosjio' }, { uri: 'hello-mother' }]