Merge pull request #376 from NYPL/SCC-4071/disable-schomburg

remove schomburg phys requestability logic

lib/requestability_resolver.js

@@ -1,6 +1,6 @@
 const DeliveryLocationsResolver = require('./delivery-locations-resolver')
 const { isItemNyplOwned } = require('./ownership_determination')
-const { isInRecap, isInSchomburg, getSchomburgDeliveryInfo } = require('./util')
+const { isInRecap } = require('./util')
 const logger = require('./logger')
 class RequestabilityResolver {
   static fixItemRequestability (elasticSearchResponse) {
@@ -26,10 +26,6 @@ class RequestabilityResolver {
             physRequestableCriteria = `${deliveryInfo.deliveryLocation &&
               deliveryInfo.deliveryLocation.length || 0} delivery locations.`
           }
-          if (isInSchomburg(item)) {
-            deliveryInfo = getSchomburgDeliveryInfo(item, deliveryInfo)
-            physRequestableCriteria = deliveryInfo.criteria
-          }
           item.eddRequestable = !!deliveryInfo.eddRequestable
           item.physRequestable = !!(deliveryInfo.deliveryLocation &&
             deliveryInfo.deliveryLocation.length)

lib/util.js

@@ -486,28 +486,3 @@ exports.isInRecap = (item) => {
     exports.itemHasRecapHoldingLocation(item) ||
     !isItemNyplOwned(item)
 }
-
-exports.isInSchomburg = (item) => {
-  const holdingLocation = exports.deepValue(item, 'holdingLocation[0].id')
-  if (holdingLocation) {
-    return holdingLocation.startsWith('loc:sc')
-  }
-}
-
-exports.getSchomburgDeliveryInfo = (item, deliveryInfo) => {
-  const itemType = exports.deepValue(item, 'catalogItemType[0].id')
-  if (itemType) {
-    const itemNumber = itemType.split(':')[1]
-    const holdingLocation = exports.deepValue(item, 'holdingLocation[0].id')
-    const case1 = holdingLocation === 'loc:scff3' && itemNumber === '26'
-    const case2 = holdingLocation === 'loc:scff2' && itemNumber === '6'
-    let criteria
-    if (case1) criteria = 'scff3 microfiche'
-    else if (case2) criteria = 'scff2 microfilm'
-    else {
-      deliveryInfo.deliveryLocation = []
-      criteria = 'Non requestable schomburg catalog item type ' + itemNumber
-    }
-    return Object.assign({}, deliveryInfo, { criteria })
-  }
-}