Merge pull request #373 from NYPL/NOREF-update-onsite-edd-critiera

Update onsite-edd critiera to match sheet

README.md

@@ -242,3 +242,4 @@ There is currently one feature flag in this app, which is 'no-on-site-edd'. When
 NB: numAvailable and numItem*Parsed counts do not **exclude** the e-item, but these items are not indexed with statuses, volumes, or date ranges, and are therefore not actually included in this count.
 
 NB: As the table above indicates, there is a mismatch between what the front end and API regard as "electronic items". As far as the API is concerned, there is only at most ONE electronic item, which can have many electronic locator values. `numElectronicResources` counts these locator values, but the other item count values treat all the electronic resources as a single item.
+

data/onsite-edd-criteria.json

@@ -34,19 +34,15 @@
     "maf",
     "maf82",
     "maf92",
-    "maff1",
     "maff3",
     "mag",
     "mag82",
     "mag92",
-    "magg1",
     "magg2",
     "magg3",
-    "magh1",
     "mai",
     "mai82",
     "mai92",
-    "maii1",
     "maii2",
     "maii3",
     "maj92",
@@ -57,21 +53,21 @@
     "mal72",
     "mal82",
     "mal92",
-    "mall1",
     "malm2",
     "malv2",
     "map",
     "map82",
     "map92",
-    "mapp1",
     "mapp2",
     "mapp3",
     "mas62",
     "mas82",
     "mas92",
     "pad22",
     "pad32",
+    "pam22",
     "pah",
+    "pah22",
     "pah32",
     "pam",
     "pam32",
@@ -80,7 +76,6 @@
     "pat22",
     "pat32",
     "scf",
-    "scff1",
     "scff2",
     "scff3"
   ]

test/delivery-locations-resolver.test.js

@@ -44,7 +44,7 @@ var sampleItems = {
     'uri': 'i12227153',
     'holdingLocation': [
       {
-        'id': 'loc:scff1',
+        'id': 'loc:scf',
         'label': 'Schomburg Center - Research & Reference'
       }
     ],