This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Offline improvements #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eload and reattempt caching.
… cache match. The service worker will always fetch an update, but may terminate before it processes the response.
namely a `<span>` for easy styling. TODO: add proper `aria` attributes so screen readers dont choke
changed the variable to contiune erasing nypl's involvement in anything associated w/ this project commented out some styles to make the the full overlay thing happen but i didnt want to get rid of them just yet
RG offline improvements
winniequinn
approved these changes
Apr 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18
This fixes #32
This fixes #45
I removed the initial popup asking if you'd like to download for offline use. Now it will always attempt to download.
I improved the error handling when attempting to load something in the iframe that's not cached. If there's an exception during iframe load, it will show an error popup with a button to try again. The button will reload the iframe and also attempt to restart the caching.