Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-REF: Update version to 4.3.3 in package.json #158

Merged
merged 1 commit into from
Apr 17, 2024
Merged

NO-REF: Update version to 4.3.3 in package.json #158

merged 1 commit into from
Apr 17, 2024

Conversation

jackiequach
Copy link
Collaborator

Update version to 4.3.3 in package.json

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-reader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 4:25pm

@samanthaandrews
Copy link
Collaborator

iirc i think the process for updating the package version number is done through the instructions here https://github.com/NYPL-Simplified/web-reader?tab=readme-ov-file#publishing-to-npm

is this correct, @kristojorg ? I don't know if I've ever even done a web-reader release before 😬

@jackiequach
Copy link
Collaborator Author

It is done there, but since I don't have permissions for the main branch it skipped that step.

@samanthaandrews
Copy link
Collaborator

It is done there, but since I don't have permissions for the main branch it skipped that step.

I made you an admin... maybe that will allow you?!

samanthaandrews
samanthaandrews approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@samanthaandrews samanthaandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think merging this will make the release show up in GitHub, which is annoying. But I do see that 4.3.3 has been released on NPM!! 🎉 https://www.npmjs.com/package/@nypl/web-reader

@jackiequach jackiequach merged commit f346346 into main Apr 17, 2024
3 checks passed
@jackiequach jackiequach deleted the NO-REF/update-package-4.3.3 branch April 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanthaandrews samanthaandrews samanthaandrews approved these changes

@kristojorg kristojorg Awaiting requested review from kristojorg kristojorg is a code owner

@Toxiapo Toxiapo Awaiting requested review from Toxiapo Toxiapo is a code owner

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc oliviawongnyc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackiequach @samanthaandrews