OE-818: Update React, Node, Chakra, and other packages #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
requested review from
samanthaandrews,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
kristojorg
approved these changes
Apr 15, 2024
package.json
Outdated
Comment on lines
37
to
43
| "peerDependencies": { | ||
| "@chakra-ui/react": "^1.8.7 || 2.x", | ||
| "@emotion/react": "^11.8.2", | ||
| "@emotion/styled": "^11.8.1", | ||
| "react": "^16.8.0 || 17.x || 18.x", | ||
| "react-dom": "^16.8.0 || 17.x || 18.x", | ||
| "swr": "^2.0.3" |
There was a problem hiding this comment.
I think these should stay as peer dependencies rather than production dependencies because it allows the dependency to be satisfied by an installing repo having a similar version
There was a problem hiding this comment.
I do think we can keep these, but they should be updated to require react 18 and chakra v2. Using chakra v2 in the consuming app while the web reader was on chakra v1 was causing some very strange styling issues.
There was a problem hiding this comment.
Oh yes true. The updates were good, just should stay peer instead of production dependencies
kristojorg
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OE-818
Tests for single- and multi- pdf are failing due to DRB being behind the VPN