This repository has been archived by the owner on Apr 11, 2022. It is now read-only.
Add a unique index to genres.name. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardr
commented
Feb 2, 2018
| @@ -8708,7 +8708,7 @@ def cautious_http_get(cls, url, headers, **kwargs): | |||
|
|
|||
| # Sites that cause problems for us if we make automated | |||
| # HTTP requests to them while trying to find free books. | |||
| AVOID_WHEN_CAUTIOUS_DOMAINS = ['gutenberg.org'] | |||
| AVOID_WHEN_CAUTIOUS_DOMAINS = ['gutenberg.org', 'books.google.com'] | |||
There was a problem hiding this comment.
This is an unrelated change to make sure an OPDS import from unglue.it doesn't try to download PDFs from Google Books. (It's impossible for an automated client to get a PDF out of Google Books, so no point in trying.)
courte
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick branch to fix an old issue (#480).
The migration script may cause problems on servers that have multiple genres with the same name, but none of NYPL's production servers are like that, so hopefully the race condition that called attention to this problem is also gone.