Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOREF NCES ID and NewRelic Updates #1918

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

mwbenowitz
Copy link
Collaborator

Description

This implements two updates:

  1. Updating our internal list of Title I schools to be as up-to-date as possible
  2. Disabling NewRelic's Distributed Tracing by default

Motivation and Context

These changes help keep the CM running smoothly with the most up to date information as possible

How Has This Been Tested?

Title I updates have been checked with the OEB team.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

This updates our internal list of school-wide Title I programs for eligibility in Open eBooks. This list is unfortunately not kept up to date so this brings it into sync as much as possible.
This disables distributed tracing in our default NewRelic configuration as it can be expensive. This setting can be updated in the `.ini` file to enable it if it is useful
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (509e1cb) to head (b34ba60).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1918   +/-   ##
========================================
  Coverage    92.56%   92.56%           
========================================
  Files          216      216           
  Lines        43665    43665           
========================================
  Hits         40418    40418           
  Misses        3247     3247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwbenowitz mwbenowitz merged commit e63744e into develop Mar 20, 2024
4 checks passed
@mwbenowitz mwbenowitz deleted the NOREF-nces-nr-updates branch March 20, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants