IOS-639 Upgrade to Xcode 15, drop iOS 11 support, remove banned books without expiration date #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettore
force-pushed
the
IOS-639/xcode15
branch
from
7a5b352 to
a6e4879
Compare
ettore
commented
Feb 1, 2024
| [record.book.defaultAcquisition.availability.until compare:[NSDate date]] == NSOrderedAscending) { | ||
| // or with no expiration | ||
| if ([acquisition.type isEqualToString:ContentTypeAxis360]) { | ||
| if ([acquisition.availability.until compare:[NSDate date]] != NSOrderedDescending) { |
There was a problem hiding this comment.
@russellcullen in objc if acquisition.availability.until is nil, the function call [nil compare:[NSDate date]] will not result in a crash and instead will just return 0. This is pretty common in objc!
So, then, 0 is != NSOrderedDescending and test succeeds 🎉
ettore
force-pushed
the
IOS-639/xcode15
branch
2 times, most recently
from
4a23260 to
cde9de0
Compare
ExplorerNautilus
approved these changes
Feb 5, 2024
Fix deprecations from dropping iOS 11.
ettore
force-pushed
the
IOS-639/xcode15
branch
from
cde9de0 to
eb531f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Why are we doing this? (w/ JIRA link if applicable)
IOS-639
How should this be tested? / Do these changes have associated tests?
Dependencies for merging? Releasing to production?
Before merging this, we should merge the following PRs:
NYPL-Simplified/NYPLAudiobookToolkit#184
https://github.com/NYPL-Simplified/DRM-iOS-Adobe/pull/28
and then update the commit refs of those 2 submodules.
Does this include changes that require a new SimplyE/Open eBooks build for QA?
not yet
Has the application documentation been updated for these changes?
yes
Did someone actually run this code to verify it works?
I did