SMA-275: Redesign the settings screen to get a better alignment with iOS

[qnga]

https://jira.nypl.org/browse/SMA-275

[MalcolmMcFly]

@qnga can you attach a screenshot of this?

[qnga]

https://nypl.slack.com/files/U01QZRJV468/F039T9ZPTNG/record_2022-04-01-17-03-19_a15a497649678411266091fae95b731c.mp4 @killerpuppytails

[robbyice]

This overall looks good but I have a few notes:

• We should endeavor to use DialogFragments for dialogs whenever possible. This might be a good opportunity to make that change.
• The SR2SettingsDialog seems like a good candidate for view and/or data binding
• If you're so inclined, you can use the coroutines-rx2 library to convert an observable to a flow. This way we can keep slowly moving the project over to fully use coroutines/flows/etc.
• Adding some tests here could be good as well (also testing will be easier with when using a DialogFragment)

[qnga]

• I like that the dialog is being dismissed on orientation change. That would not happen with DialogFragment whose I think it's the main feature.
• There is no significant advantage, so I preferred consistency. I consider this repo to be in maintenance mode.
• I'm not used to UI tests and not convinced they are a great thing. Mocking-based fragile tests in core make every change time-wasting and very painful, and I believe that UI tests are even more fragile. Besides, I manually tested all features in this dialog and as it's an independent piece of code, it shouldn't be broken accidentally by anything else. Feel free to try to convince me if you like.

[robbyice]

I think wanting the dialog to dismiss on orientation change is reasonable. Using DialogFragment would protect it against any configuration change, which includes other situations, but it's probably not necessary if we're not worried about ensuring the dialog stays open.

I'd like to move the codebase towards consistency around new, more modern Android patterns, rather than consistency with things as they are. I don't think it's a requirement for this ticket but it's something to think about.

I'm happy to have a separate conversation about the benefits of testing. UI testing in Android has indeed been historically fragile, but the ecosystem is significantly better nowadays. There are some good examples of unit tests for fragments/viewmodels in the core repo.