Merge pull request #33 from Latios96/fix-default-arguments-mutation

fix default argument mutation
NVlabs · May 28, 2024 · a28b009 · a28b009
2 parents d04c585 + 1efff80
commit a28b009
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/python/flip/main.cpp b/python/flip/main.cpp
@@ -232,10 +232,11 @@ std::tuple<py::array_t<float>, float, py::dict> evaluate(const py::array_t<float
         }
     }
     delete flip;
+
+    py::dict returnParams = {};
+    updateInputParameters(parameters, returnParams);
 
-    updateInputParameters(parameters, inputParameters);
-
-    return std::make_tuple(flipNumpy, meanError, inputParameters);
+    return std::make_tuple(flipNumpy, meanError, returnParams);
 }
 
 // Create command line, based on the Python command line string, for the FLIP tool to parse.