Update and clean up the quickstart README file #112
Conversation
|
/cc @klueska |
| kubectl apply --filename=gpu-test{1,2,3,4}.yaml | ||
| kubectl apply --filename=gpu-test{1,2,3}.yaml |
There was a problem hiding this comment.
Interesting -- I though I had purposfully removed demo 4 from this READMe for exactly this reason. Maybe I only did it here, but not in our actual driver repo: https://github.com/kubernetes-sigs/dra-example-driver
There was a problem hiding this comment.
Ah -- I see now. This is the file down in the quickstart folder -- yeah, this was just copied from my demo script when I presented this.
There was a problem hiding this comment.
It seems to me that test-4 (MIG demo) is different from the other three. We also describe test-4 separately in detail later. I think the descriptions would be clearer if we separated them.
There was a problem hiding this comment.
Makes sense to update this to only include examples that can be run on any GPU and separate out the MIG use cases to another folder.
There was a problem hiding this comment.
Agree, test-5/6 are MIG examples too. We didn't even describe them in README. Let me update the PR.
There was a problem hiding this comment.
Created a new folder mig and moved the MIG example gpu-test4/5/6 to it and updated README files accordingly.
Signed-off-by: Yuan Chen <[email protected]> Add link Signed-off-by: Yuan Chen <[email protected]> Minor typo fix Signed-off-by: Yuan Chen <[email protected]> Add a new folder mig
The current README does't read well. This PR updates the description and flow.
gpu-test-4/5/6) in a new folder from the first 3 test examples and update the flow.gpu-test-mps.