payloads: web-related, incl. probes.encoding migration
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leondz
added
architecture
leondz
changed the title
probes.encoding migrationprobes.encoding migration
… reduce volume of payload scans
|
Lets consider making the exposed entry point for |
jmartin-tech
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Does it make sense to have consistent DEFAULT_PARAMS naming as payload_name? Examples of impact noted in the review.
Also looking at this payload_trigger being populated directly with the payloads set seems non-intuitive, but I don't have a better alternative to offer at this time so reasonable to live with for now.
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Leon Derczynski <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Leon Derczynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out web-related payloads, and complete the transition to
garak.payloadsuse inprobes.encodingVerification
garak -m test -g 1 -p encoding,latentinjection,xssand check thereport.jsonls include appropriate payload textpython -m pytest tests/test_payloads.pypython -m pytest tests/probes/test_probes_encoding.pypython -m pytest tests/probes/test_probes_latentinjection.py