Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor attempt to utilized property annotations #1027

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jmartin-tech
Copy link
Collaborator

Fix #995

This removed the override of class setattr and getattr in favor of the property annotations to enable deepcopy

Verification

  • Verify attempt tests pass with no changes
  • Verify run against a model in a debugger and validate that probes base is no longer swallowing an exception on deepcopy

This removed the override of class setattr and getattr in favor
of the `property` annotations to enable deepcopy

Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much tidier

@jmartin-tech jmartin-tech merged commit 3ee53a8 into NVIDIA:main Dec 2, 2024
9 checks passed
@jmartin-tech jmartin-tech deleted the task/refactor-attempt branch December 2, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Refactor attempt to not override getters & setters
2 participants