Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: enable configuration updates #1026
Feature: enable configuration updates #1026
Changes from 6 commits
3f0eb81
252c97d
2d90a6a
b907003
29d337c
a54ae57
0a06d39
426f52e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what uses
aliases
? same comment for other probesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently just for
--plugin_info
output, I could see skipping them or enablinginteractive
to use them later as hints for outdated command requests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm into it -- it enables deprecation pretty easily too. Could warn on the use of aliases and fix it at some point, especially via interactive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that's cool. we might like to choose now how diligent we intend to be about this - are
aliases
only given as indications, or do we guarantee that they're exhaustive?there's a duplication of info here (because it's already given in
fixer
modules) that i'm mindful ofThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed I tried to note in the description this becomes a
required
step when adding a migration that impacts a plugin name however there is no enforcement/early warning mechanism currently in place, we could add alint
like action that checks for plugin file or class renames as a warning/hint on PRs.