Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS #1001

Merged
merged 1 commit into from
Nov 14, 2024
Merged

add CODEOWNERS #1001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/.github/ @leondz @erickgalinkin @jmartin-tech
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to add ourselves as global owners for review tagging? Or are we only aiming for branch protection for the CODEOWNERS file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say no, I do not currently want all PRs to auto-request review.

This is intended for protection of automation artifacts by requiring a maintainer to approve landing any PR that may change those workflows. I can see a future where there are experts on certain segments of the codebase that would be desirable to tag on reviews of changes in those areas, the project is not that complex at this time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a .github restriction, separate from global config/restrictions, is a good extra layer of protection

Loading