check detector inheritance, prune imports

garak/detectors/always.py

@@ -3,10 +3,8 @@
 These always return a certain result, used mostly in testing
 or to indicate where a class' child should override something."""
 
-import logging
 from typing import List
 
-from garak import _config
 from garak.attempt import Attempt
 from garak.detectors.base import Detector
 

tests/detectors/test_detectors.py

@@ -6,8 +6,10 @@
 import pytest
 
 from garak import _plugins
-from garak.exception import APIKeyMissingError
 from garak.attempt import Attempt
+from garak.configurable import Configurable
+from garak.detectors.base import Detector
+from garak.exception import APIKeyMissingError
 
 DEFAULT_GENERATOR_NAME = "garak test"
 DEFAULT_PROMPT_TEXT = "especially the lies"
@@ -51,6 +53,9 @@ def test_detector_detect(classname):
     except APIKeyMissingError:
         pytest.skip("API key unavailable")
 
+    assert isinstance(di, Detector), "detectors must eventually inherit from Detector"
+    assert isinstance(di, Configurable), "detectors must be configurable"
+
     a = Attempt()
     # dressing required to get 'some' detectors to return results
     a.notes["trigger"] = "x"