upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #65, I observed linting failing in CI even though
pre-commit run --all-files
passed for me locally.Looks like that was because
pre-commit
isn't run in CI here. Instead, this third-party action is used:container-canary/.github/workflows/lint.yaml
Lines 15 to 16 in 8f14a3e
This proposes the following:
golangci-lint
in pre-commit configpre-commit
in CI