Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks #67

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jameslamb
Copy link
Member

On #65, I observed linting failing in CI even though pre-commit run --all-files passed for me locally.

Looks like that was because pre-commit isn't run in CI here. Instead, this third-party action is used:

- name: golangci-lint
uses: golangci/golangci-lint-action@v4

This proposes the following:

  • update to the latest version of golangci-lint in pre-commit config
  • add a few more small pre-commit hooks (for trailing whitespace and newlines)
  • run pre-commit in CI

@jameslamb jameslamb added the CI Related to running tests and releasing label Jul 31, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2024
Signed-off-by: James Lamb <[email protected]>
@jameslamb jameslamb changed the title WIP: [NOT READY FOR REVIEW] upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks Jul 31, 2024
@jameslamb jameslamb marked this pull request as ready for review July 31, 2024 21:50
@jameslamb jameslamb requested a review from a team as a code owner July 31, 2024 21:50
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jacobtomlinson jacobtomlinson merged commit 2e70e2b into NVIDIA:main Aug 1, 2024
7 checks passed
@jameslamb jameslamb deleted the ci/pre-commit branch August 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to running tests and releasing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants