add tests

Signed-off-by: James Lamb <[email protected]>

Makefile

@@ -36,6 +36,7 @@ test: ## Run tests
 testprep: ## Run test prerequisite tasks
 	docker build -t container-canary/kubeflow:shouldpass -f internal/testdata/containers/kubeflow.Dockerfile .
 	docker build -t container-canary/kubeflow:shouldfail -f internal/testdata/containers/kubeflow_broken.Dockerfile .
+	docker build -t container-canary/long-sleep:local - <   internal/testdata/containers/long-sleep.Dockerfile
 
 version:
 	@echo version: $(VERSION)

cmd/validate_test.go

@@ -60,3 +60,15 @@ func TestFileDoesNotExist(t *testing.T) {
 	assert.NotNil(err, "did not error")
 	assert.Contains(b.String(), "Cannot find container-canary/kubeflow:doesnotexist", "did not fail")
 }
+
+func TestValidateRespectsStartupTimeout(t *testing.T) {
+	assert := assert.New(t)
+	b := new(bytes.Buffer)
+	rootCmd.SetOut(b)
+	rootCmd.SetErr(b)
+	rootCmd.SetArgs([]string{"validate", "--file", "../examples/kubeflow.yaml", "container-canary/long-sleep:local", "--startup-timeout", "3"})
+	err := rootCmd.Execute()
+
+	assert.NotNil(err, "should fail")
+	assert.Contains(b.String(), "validation failed", "container failed to start after 3 seconds")
+}

internal/testdata/containers/long-sleep.Dockerfile

@@ -0,0 +1,3 @@
+FROM alpine
+
+CMD [ "sleep", "60" ]

internal/validator/tui.go

@@ -134,7 +134,6 @@ func handleConfigLoaded(m model, msg configLoaded) (model, tea.Cmd) {
 	if !m.tty {
 		commands = append(commands, tea.Printf("Starting container"))
 	}
-	// right here... m.container isn't set yet
 	commands = append(commands, startContainer(m.image, m.validator, m.containerStartupTimeout))
 	return m, tea.Batch(commands...)
 }