Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T5 changes based on mcore changes #9829

Merged
merged 1 commit into from
Jul 22, 2024
Merged

T5 changes based on mcore changes #9829

merged 1 commit into from
Jul 22, 2024

Conversation

pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay commented Jul 22, 2024 •
edited
Loading

@pablo-garay pablo-garay requested a review from huvunvidia July 22, 2024 19:06
@pablo-garay pablo-garay requested a review from ericharper July 22, 2024 19:20
huvunvidia
huvunvidia approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@huvunvidia huvunvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One job (L2_QAT_Llama2_INT4) failed. I just restarted the job.

@pablo-garay
Copy link
Collaborator Author

LGTM. One job (L2_QAT_Llama2_INT4) failed. I just restarted the job.

Job that failed optional - not required. Merging ...

@pablo-garay pablo-garay reopened this Jul 22, 2024
@pablo-garay pablo-garay merged commit 66bebc7 into r2.0.0rc1 Jul 22, 2024
123 of 124 checks passed
@pablo-garay pablo-garay deleted the pagaray/mcore_t5 branch July 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huvunvidia huvunvidia huvunvidia approved these changes

@ericharper ericharper Awaiting requested review from ericharper

Assignees
No one assigned
Labels
CI NLP Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablo-garay @huvunvidia