Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hf hub for 0.24+ #9806

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Fix hf hub for 0.24+ #9806

merged 6 commits into from
Jul 23, 2024

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Fix the deprecation of ModelFilter

Collection: [Core]

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

titu1994 added 3 commits July 19, 2024 10:39
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
@github-actions github-actions bot added the core Changes to NeMo Core label Jul 19, 2024
titu1994 and others added 2 commits July 19, 2024 13:42
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 6ff5bce into r2.0.0rc1 Jul 23, 2024
118 checks passed
@ericharper ericharper deleted the fix_hf branch July 23, 2024 23:34
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
* Update Huggingface Hub support

Signed-off-by: smajumdar <[email protected]>

* Update hf hub

Signed-off-by: smajumdar <[email protected]>

* Update hf hub

Signed-off-by: smajumdar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: titu1994 <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
titu1994 added a commit that referenced this pull request Jul 24, 2024
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Somshubra Majumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants