[NeMo-UX] Use single instance of loss reductions in GPTModel #9801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemildesai
changed the title
hemildesai
changed the title
hemildesai
force-pushed
the
hemil/potential-memory-fix
branch
from
b66e35d to
6306228
Compare
ShriyaPalsamudram
approved these changes
Jul 19, 2024
ShriyaPalsamudram
previously approved these changes
Jul 19, 2024
ericharper
reviewed
Jul 19, 2024
Comment on lines
28
to
29
| TRAIN_LOSS_REDUCTION = MaskedTokenLossReduction() | ||
| VALIDATION_LOSS_REDUCTION = MaskedTokenLossReduction(validation_step=True) |
There was a problem hiding this comment.
Let's comment that this is a temporary WAR.
There was a problem hiding this comment.
Or remove the globals.
akoumpa
approved these changes
Jul 22, 2024
hemildesai
force-pushed
the
hemil/potential-memory-fix
branch
2 times, most recently
from
6d35351 to
537259b
Compare
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
hemildesai
force-pushed
the
hemil/potential-memory-fix
branch
from
537259b to
eded322
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Use single instance of loss reductions Signed-off-by: Hemil Desai <[email protected]> * Apply isort and black reformatting Signed-off-by: hemildesai <[email protected]> * Refactor Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: hemildesai <[email protected]>
hemildesai
added a commit
that referenced
this pull request
Jul 31, 2024
* Use single instance of loss reductions Signed-off-by: Hemil Desai <[email protected]> * Apply isort and black reformatting Signed-off-by: hemildesai <[email protected]> * Refactor Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: hemildesai <[email protected]>
hemildesai
added a commit
that referenced
this pull request
Aug 1, 2024
…9861) * Use single instance of loss reductions * Apply isort and black reformatting * Refactor --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: Hemil Desai <[email protected]> Co-authored-by: hemildesai <[email protected]>
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
…9801) (NVIDIA#9861) * Use single instance of loss reductions * Apply isort and black reformatting * Refactor --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: Hemil Desai <[email protected]> Co-authored-by: hemildesai <[email protected]> Signed-off-by: adityavavre <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
…9861) * Use single instance of loss reductions * Apply isort and black reformatting * Refactor --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: Hemil Desai <[email protected]> Co-authored-by: hemildesai <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
…9801) (NVIDIA#9861) * Use single instance of loss reductions * Apply isort and black reformatting * Refactor --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: Hemil Desai <[email protected]> Co-authored-by: hemildesai <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Uses a singleton for
training_loss_reductionandvalidation_loss_reductioninGPTModel.Collection: llm
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information