Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI format response to r2.0.0rc1 #9796

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

athitten
Copy link
Collaborator

@athitten athitten commented Jul 18, 2024

What does this PR do ?

Replica of PR: #9726 which has been merged to main. This PR adds it to https://github.com/NVIDIA/NeMo/tree/r2.0.0rc1 branch as its required for 24.07 release.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@athitten athitten requested a review from oyilmaz-nvidia July 18, 2024 18:09
Copy link
Collaborator

@oyilmaz-nvidia oyilmaz-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericharper ericharper added bug Something isn't working 2.0.0rc1 Run CICD and removed Run CICD labels Jul 19, 2024
@athitten athitten merged commit a52ee73 into r2.0.0rc1 Jul 22, 2024
118 checks passed
@athitten athitten deleted the athitten/r2.0.0rc1_openai_format_response branch July 22, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants