Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NeMo-UX] Adding recipes #9720

Merged
merged 27 commits into from
Jul 23, 2024
Merged

[NeMo-UX] Adding recipes #9720

merged 27 commits into from
Jul 23, 2024

Conversation

marcromeyn
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@marcromeyn marcromeyn changed the title Nemo ux/llm factories [NeMo-UX] Adding recipies Jul 12, 2024
@marcromeyn marcromeyn changed the title [NeMo-UX] Adding recipies [NeMo-UX] Adding recipes Jul 12, 2024
@marcromeyn marcromeyn force-pushed the nemo-ux/llm-factories branch 2 times, most recently from 7e13c5c to 88cc473 Compare July 12, 2024 15:50
@ashors1 ashors1 requested review from ashors1 and hemildesai July 17, 2024 18:35
marcromeyn and others added 16 commits July 17, 2024 17:20
Signed-off-by: artbataev <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 force-pushed the nemo-ux/llm-factories branch from a8dae3e to 71e36fb Compare July 18, 2024 00:20
@ashors1 ashors1 marked this pull request as ready for review July 18, 2024 00:21
hemildesai and others added 2 commits July 17, 2024 19:05
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
@hemildesai hemildesai force-pushed the nemo-ux/llm-factories branch from e4d1dbf to 3d63241 Compare July 18, 2024 02:05
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 18, 2024
@ashors1 ashors1 requested review from cuichenx and akoumpa July 19, 2024 03:30
Copy link
Member

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the directory models to recipes?

Otherwise it's confusing why there's a mistral.py under both collections/llm/gpt/model and collections/llm/models.
I don't have any strong preference as long as one of the two directories changes name.

@ashors1
Copy link
Collaborator

ashors1 commented Jul 20, 2024

Can we rename the directory models to recipes?

Otherwise it's confusing why there's a mistral.py under both collections/llm/gpt/model and collections/llm/models. I don't have any strong preference as long as one of the two directories changes name.

Done

@ashors1 ashors1 requested a review from akoumpa July 20, 2024 00:16
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 20, 2024
@akoumpa akoumpa merged commit b7a494e into r2.0.0rc1 Jul 23, 2024
118 checks passed
@akoumpa akoumpa deleted the nemo-ux/llm-factories branch July 23, 2024 16:14
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
* Adding recipy proposal

Signed-off-by: ashors1 <[email protected]>

* Adding more recipies

Signed-off-by: ashors1 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: artbataev <[email protected]>
Signed-off-by: ashors1 <[email protected]>

* Remove api.py inside llm.gpt.model

Signed-off-by: ashors1 <[email protected]>

* Adding resume to FineTuneRecipy

Signed-off-by: ashors1 <[email protected]>

* Fix spelling error

Signed-off-by: ashors1 <[email protected]>

* Fix spelling error

Signed-off-by: ashors1 <[email protected]>

* Fix spelling error

Signed-off-by: ashors1 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>

* Adding resume to PreTrainRecipe

Signed-off-by: ashors1 <[email protected]>

* update recipe proposal to use sdk.Partial

Signed-off-by: ashors1 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>

* update __init__

Signed-off-by: ashors1 <[email protected]>

* update __init__

Signed-off-by: ashors1 <[email protected]>

* fix return type

Signed-off-by: ashors1 <[email protected]>

* Fix bug in factory

Signed-off-by: ashors1 <[email protected]>

* rename recipe folder to 'models'

Signed-off-by: ashors1 <[email protected]>

* Fixes

Signed-off-by: Hemil Desai <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hemildesai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>

* Bug fixes

Signed-off-by: Hemil Desai <[email protected]>

* rename models --> configs

Signed-off-by: ashors1 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: ashors1 <[email protected]>

* rename configs --> recipes

Signed-off-by: ashors1 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: ashors1 <[email protected]>

* address comments

Signed-off-by: ashors1 <[email protected]>

---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
ashors1 added a commit that referenced this pull request Jul 30, 2024
* Adding recipy proposal



* Adding more recipies



* Apply isort and black reformatting




* Remove api.py inside llm.gpt.model



* Adding resume to FineTuneRecipy



* Fix spelling error



* Fix spelling error



* Fix spelling error



* Apply isort and black reformatting




* Adding resume to PreTrainRecipe



* update recipe proposal to use sdk.Partial



* Apply isort and black reformatting




* update __init__



* update __init__



* fix return type



* Fix bug in factory



* rename recipe folder to 'models'



* Fixes



* Apply isort and black reformatting




* Bug fixes



* rename models --> configs



* Apply isort and black reformatting



* rename configs --> recipes



* Apply isort and black reformatting



* address comments



---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: Marc Romeyn <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
Co-authored-by: Anna Shors <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
* Adding recipy proposal

* Adding more recipies

* Apply isort and black reformatting

* Remove api.py inside llm.gpt.model

* Adding resume to FineTuneRecipy

* Fix spelling error

* Fix spelling error

* Fix spelling error

* Apply isort and black reformatting

* Adding resume to PreTrainRecipe

* update recipe proposal to use sdk.Partial

* Apply isort and black reformatting

* update __init__

* update __init__

* fix return type

* Fix bug in factory

* rename recipe folder to 'models'

* Fixes

* Apply isort and black reformatting

* Bug fixes

* rename models --> configs

* Apply isort and black reformatting

* rename configs --> recipes

* Apply isort and black reformatting

* address comments

---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: Marc Romeyn <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
Co-authored-by: Anna Shors <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
* Adding recipy proposal

* Adding more recipies

* Apply isort and black reformatting

* Remove api.py inside llm.gpt.model

* Adding resume to FineTuneRecipy

* Fix spelling error

* Fix spelling error

* Fix spelling error

* Apply isort and black reformatting

* Adding resume to PreTrainRecipe

* update recipe proposal to use sdk.Partial

* Apply isort and black reformatting

* update __init__

* update __init__

* fix return type

* Fix bug in factory

* rename recipe folder to 'models'

* Fixes

* Apply isort and black reformatting

* Bug fixes

* rename models --> configs

* Apply isort and black reformatting

* rename configs --> recipes

* Apply isort and black reformatting

* address comments

---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: Marc Romeyn <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
Co-authored-by: Anna Shors <[email protected]>
Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Adding recipy proposal



* Adding more recipies



* Apply isort and black reformatting




* Remove api.py inside llm.gpt.model



* Adding resume to FineTuneRecipy



* Fix spelling error



* Fix spelling error



* Fix spelling error



* Apply isort and black reformatting




* Adding resume to PreTrainRecipe



* update recipe proposal to use sdk.Partial



* Apply isort and black reformatting




* update __init__



* update __init__



* fix return type



* Fix bug in factory



* rename recipe folder to 'models'



* Fixes



* Apply isort and black reformatting




* Bug fixes



* rename models --> configs



* Apply isort and black reformatting



* rename configs --> recipes



* Apply isort and black reformatting



* address comments



---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: Marc Romeyn <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
Co-authored-by: Anna Shors <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Adding recipy proposal



* Adding more recipies



* Apply isort and black reformatting




* Remove api.py inside llm.gpt.model



* Adding resume to FineTuneRecipy



* Fix spelling error



* Fix spelling error



* Fix spelling error



* Apply isort and black reformatting




* Adding resume to PreTrainRecipe



* update recipe proposal to use sdk.Partial



* Apply isort and black reformatting




* update __init__



* update __init__



* fix return type



* Fix bug in factory



* rename recipe folder to 'models'



* Fixes



* Apply isort and black reformatting




* Bug fixes



* rename models --> configs



* Apply isort and black reformatting



* rename configs --> recipes



* Apply isort and black reformatting



* address comments



---------

Signed-off-by: ashors1 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Co-authored-by: Marc Romeyn <[email protected]>
Co-authored-by: artbataev <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: ashors1 <[email protected]>
Co-authored-by: Hemil Desai <[email protected]>
Co-authored-by: hemildesai <[email protected]>
Co-authored-by: Anna Shors <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants