Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: notebook branch release #9711

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jul 12, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/notebook-branch-release branch 3 times, most recently from 13e2a71 to b4374a1 Compare July 12, 2024 10:17
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/notebook-branch-release branch from 92af144 to 2668a18 Compare July 12, 2024 10:21
@ko3n1g ko3n1g changed the title Ko3n1g/refactor/notebook branch release refactor: notebook branch release Jul 12, 2024
@ko3n1g ko3n1g requested a review from ericharper July 12, 2024 10:21
@ko3n1g ko3n1g marked this pull request as ready for review July 12, 2024 10:21
@ericharper ericharper merged commit a5cdaf0 into r2.0.0rc1 Jul 12, 2024
10 checks passed
@ericharper ericharper deleted the ko3n1g/refactor/notebook-branch-release branch July 12, 2024 16:22
github-actions bot pushed a commit that referenced this pull request Jul 12, 2024
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
dimapihtar pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants