Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dummy vision and text transformer config (assumed mcore to be false) #9699

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

rohitrango
Copy link
Contributor

What does this PR do ?

Add parameters to CLIP model loading for SD training.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@rohitrango
Copy link
Contributor Author

@yaoyu-33

@yaoyu-33 yaoyu-33 merged commit d036c41 into NVIDIA:r2.0.0rc1 Jul 22, 2024
124 of 125 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
…se) (#9699)

* add dummy vision and text transformer config (assumed mcore to be false)

Signed-off-by: Rohit Jena <[email protected]>

* Apply isort and black reformatting

Signed-off-by: rohitrango <[email protected]>

---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
ericharper pushed a commit that referenced this pull request Jul 24, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Jul 24, 2024
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
Signed-off-by: Vivian Chen <[email protected]>
kchike pushed a commit to kchike/NeMo that referenced this pull request Aug 8, 2024
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
Signed-off-by: kchike <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: rohitrango <[email protected]>
Co-authored-by: Rohit Jena <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants