Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick: LITA Integration #9684

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Cherry pick: LITA Integration #9684

merged 1 commit into from
Jul 11, 2024

Conversation

Slyne
Copy link
Contributor

@Slyne Slyne commented Jul 11, 2024

What does this PR do ?

To cherry pick #9578 LITA integration into 2.0.0rc1. That PR was already merged. See details there.

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]
NLP and multimodal

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Slyne Deng <[email protected]>
@pablo-garay
Copy link
Collaborator

1 similar comment
@pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay merged commit fafeb22 into NVIDIA:r2.0.0rc1 Jul 11, 2024
111 of 112 checks passed
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants