Fix for train.controlnet.controlnet_v1_5_1node_100steps
#9678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitrango
force-pushed
the
rohitrango/controlnet_cibug
branch
from
7dc6069 to
470034b
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
directly from the unet. also added a checkpoint converter for SD that converts both SD and SDXL Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: Rohit Jena <[email protected]>
rohitrango
force-pushed
the
rohitrango/controlnet_cibug
branch
from
c01c3a3 to
95a8a98
Compare
Victor49152
reviewed
Jul 29, 2024
nemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py
Outdated
Show resolved
Hide resolved
Victor49152
previously approved these changes
Jul 29, 2024
Signed-off-by: Rohit Jena <[email protected]>
Signed-off-by: Victor49152 <[email protected]>
Victor49152
approved these changes
Jul 31, 2024
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* Fixed bug with controlnet where the model can be assumed to be saved directly from the unet. also added a checkpoint converter for SD that converts both SD and SDXL Signed-off-by: Rohit Jena <[email protected]> * delete unnecessary comments and messages Signed-off-by: Rohit Jena <[email protected]> * reinstate try-catch for loading missing modules Signed-off-by: Rohit Jena <[email protected]> * Apply isort and black reformatting Signed-off-by: Victor49152 <[email protected]> --------- Signed-off-by: Rohit Jena <[email protected]> Signed-off-by: Victor49152 <[email protected]> Co-authored-by: Rohit Jena <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Victor49152 <[email protected]> Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Fixed bug with controlnet where the model can be assumed to be saved directly from the unet. also added a checkpoint converter for SD that converts both SD and SDXL Signed-off-by: Rohit Jena <[email protected]> * delete unnecessary comments and messages Signed-off-by: Rohit Jena <[email protected]> * reinstate try-catch for loading missing modules Signed-off-by: Rohit Jena <[email protected]> * Apply isort and black reformatting Signed-off-by: Victor49152 <[email protected]> --------- Signed-off-by: Rohit Jena <[email protected]> Signed-off-by: Victor49152 <[email protected]> Co-authored-by: Rohit Jena <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Victor49152 <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Fixed bug with controlnet where the model can be assumed to be saved directly from the unet. also added a checkpoint converter for SD that converts both SD and SDXL Signed-off-by: Rohit Jena <[email protected]> * delete unnecessary comments and messages Signed-off-by: Rohit Jena <[email protected]> * reinstate try-catch for loading missing modules Signed-off-by: Rohit Jena <[email protected]> * Apply isort and black reformatting Signed-off-by: Victor49152 <[email protected]> --------- Signed-off-by: Rohit Jena <[email protected]> Signed-off-by: Victor49152 <[email protected]> Co-authored-by: Rohit Jena <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Victor49152 <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes
train.controlnet.controlnet_v1_5_1node_100stepsCI test.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information