Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling bias_dropout_add_fused with no bias term #9676

Closed
wants to merge 2 commits into from

Conversation

ashvinnihalani
Copy link

@ashvinnihalani ashvinnihalani commented Jul 10, 2024

What does this PR do ?

Specific LLM/VLM hang when using specific PP settings and with the bias term is set to false hang. By enabling a fused dropout_add_fused we should fix this problem as well as speed up training of LLM/VLM that do not have the bias term

Collection: nlp

Changelog

  • Add specific line by line info of high level changes in this PR.
  • nemo/collections/nlp/modules/common/megatron/transformer.py - Enabling the bias_dropout_add_fusion to be used for both bias and non bias enabled
  • nemo/collections/nlp/modules/common/megatron/fused_bias_dropout_add.py - Check whether the bias term is there and choose relevant fused function

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • [N/A] Did you write any new necessary tests?
  • [ X] Did you add or update any necessary documentation?
  • [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [N/A] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [N/A] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@github-actions github-actions bot added the NLP label Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update bias_dropout_add_fused_inference_ to check if bias exists? otherwise it seems the type would mismatch when doing x + bias

@paul-gibbons
Copy link
Collaborator

@yaoyu-33

Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 8, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants