Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherrypick] support lora when kv_channel != hidden_size / num_heads #9644

Merged
merged 2 commits into from
Jul 8, 2024
Merged

[Cherrypick] support lora when kv_channel != hidden_size / num_heads #9644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6436015
support lora when kv_channel != hidden_size / num_heads
suiyoubi Jul 8, 2024
e8372d9
Merge branch 'r2.0.0rc1' into aot/peft_fix
cuichenx Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo/collections/nlp/parts/peft_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def __init__(self, cfg):

elif module == PEFT_MODULE_MAP["dense_module"]:
adapter_cfg = self._create_lora_config(
cfg, lora_cfg, cfg.hidden_size, cfg.hidden_size, LoraDenseAttentionAdapterConfig
cfg, lora_cfg, projection_size, cfg.hidden_size, LoraDenseAttentionAdapterConfig
)
name_key_to_cfg[AdapterName.LORA_DENSE_ATTENTION_ADAPTER] = adapter_cfg
name_key_to_mcore_mixins[AdapterName.LORA_DENSE_ATTENTION_ADAPTER] = [
Expand Down
Loading