Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default parallel_save to False #9633

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Change default parallel_save to False #9633

merged 1 commit into from
Jul 8, 2024

Conversation

mikolajblaz
Copy link
Collaborator

What does this PR do ?

Cheery-pick of #9632 to r2.0 branch

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@mikolajblaz mikolajblaz requested a review from dimapihtar July 8, 2024 09:21
@mikolajblaz mikolajblaz self-assigned this Jul 8, 2024
@mikolajblaz mikolajblaz changed the base branch from main to r2.0.0rc1 July 8, 2024 09:23
dimapihtar
dimapihtar approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mikolajblaz mikolajblaz merged commit 0661390 into r2.0.0rc1 Jul 8, 2024
115 checks passed
@mikolajblaz mikolajblaz deleted the mblaz/default-non-parallel-r2.0-cherry-pick branch July 8, 2024 11:12
dimapihtar added a commit that referenced this pull request Jul 11, 2024
@dimapihtar @mikolajblaz
add documentation for reset_lr feature (#9639)
cf167e6 
* Change default parallel_save to False (#9633)

Signed-off-by: Mikołaj Błaż <[email protected]>

* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)

Signed-off-by: Mikołaj Błaż <[email protected]>

* add reset_lr documentation

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* add image

Signed-off-by: dimapihtar <[email protected]>

* fix typo

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* change plot size

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* move image

Signed-off-by: dimapihtar <[email protected]>

* add reset_lr to intro page

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
@dimapihtar @mikolajblaz @web-flow
add documentation for reset_lr feature (#9639)
d4c5c54 
* Change default parallel_save to False (#9633)

Signed-off-by: Mikołaj Błaż <[email protected]>

* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)

Signed-off-by: Mikołaj Błaż <[email protected]>

* add reset_lr documentation

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* add image

Signed-off-by: dimapihtar <[email protected]>

* fix typo

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* change plot size

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* move image

Signed-off-by: dimapihtar <[email protected]>

* add reset_lr to intro page

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
maanug-nv pushed a commit that referenced this pull request Jul 14, 2024
@dimapihtar @mikolajblaz @maanug-nv
add documentation for reset_lr feature (#9639)
088653e 
* Change default parallel_save to False (#9633)

Signed-off-by: Mikołaj Błaż <[email protected]>

* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)

Signed-off-by: Mikołaj Błaż <[email protected]>

* add reset_lr documentation

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* add image

Signed-off-by: dimapihtar <[email protected]>

* fix typo

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* change plot size

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* move image

Signed-off-by: dimapihtar <[email protected]>

* add reset_lr to intro page

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
dimapihtar added a commit that referenced this pull request Aug 27, 2024
@dimapihtar @mikolajblaz
add documentation for reset_lr feature (#9639)
6439673 
* Change default parallel_save to False (#9633)

Signed-off-by: Mikołaj Błaż <[email protected]>

* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)

Signed-off-by: Mikołaj Błaż <[email protected]>

* add reset_lr documentation

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* add image

Signed-off-by: dimapihtar <[email protected]>

* fix typo

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* change plot size

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* move image

Signed-off-by: dimapihtar <[email protected]>

* add reset_lr to intro page

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
dimapihtar added a commit that referenced this pull request Aug 28, 2024
@dimapihtar @mikolajblaz
add documentation for reset_lr feature (#9639)
088755d 
* Change default parallel_save to False (#9633)

Signed-off-by: Mikołaj Błaż <[email protected]>

* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)

Signed-off-by: Mikołaj Błaż <[email protected]>

* add reset_lr documentation

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* add image

Signed-off-by: dimapihtar <[email protected]>

* fix typo

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* fix plot

Signed-off-by: dimapihtar <[email protected]>

* change plot size

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* move image

Signed-off-by: dimapihtar <[email protected]>

* add reset_lr to intro page

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
ericharper pushed a commit that referenced this pull request Aug 29, 2024
@dimapihtar @mikolajblaz
add documentation for reset_lr feature (#9639) (#10290)
eff7ddd 
* Change default parallel_save to False (#9633)



* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)



* add reset_lr documentation



* fix style



* fix style



* fix style



* add image



* fix typo



* fix plot



* fix plot



* change plot size



* fix style



* move image



* add reset_lr to intro page



---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
@dimapihtar @mikolajblaz @adityavavre
add documentation for reset_lr feature (NVIDIA#9639) (NVIDIA#10290)
6a99586 
* Change default parallel_save to False (NVIDIA#9633)

* Unwrap ckpt_io for model opt (async save) (NVIDIA#9622) (NVIDIA#9634)

* add reset_lr documentation

* fix style

* fix style

* fix style

* add image

* fix typo

* fix plot

* fix plot

* change plot size

* fix style

* move image

* add reset_lr to intro page

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
Signed-off-by: adityavavre <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@dimapihtar @mikolajblaz @monica-sekoyan
add documentation for reset_lr feature (#9639) (#10290)
dbca48b 
* Change default parallel_save to False (#9633)



* Unwrap ckpt_io for model opt (async save) (#9622) (#9634)



* add reset_lr documentation



* fix style



* fix style



* fix style



* add image



* fix typo



* fix plot



* fix plot



* change plot size



* fix style



* move image



* add reset_lr to intro page



---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
@dimapihtar @mikolajblaz @tomlifu
add documentation for reset_lr feature (NVIDIA#9639) (NVIDIA#10290)
d29e33b 
* Change default parallel_save to False (NVIDIA#9633)

* Unwrap ckpt_io for model opt (async save) (NVIDIA#9622) (NVIDIA#9634)

* add reset_lr documentation

* fix style

* fix style

* fix style

* add image

* fix typo

* fix plot

* fix plot

* change plot size

* fix style

* move image

* add reset_lr to intro page

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
@dimapihtar @mikolajblaz @tomlifu
add documentation for reset_lr feature (NVIDIA#9639) (NVIDIA#10290)
16e0b73 
* Change default parallel_save to False (NVIDIA#9633)

* Unwrap ckpt_io for model opt (async save) (NVIDIA#9622) (NVIDIA#9634)

* add reset_lr documentation

* fix style

* fix style

* fix style

* add image

* fix typo

* fix plot

* fix plot

* change plot size

* fix style

* move image

* add reset_lr to intro page

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@dimapihtar @mikolajblaz
add documentation for reset_lr feature (NVIDIA#9639) (NVIDIA#10290)
293a7a7 
* Change default parallel_save to False (NVIDIA#9633)



* Unwrap ckpt_io for model opt (async save) (NVIDIA#9622) (NVIDIA#9634)



* add reset_lr documentation



* fix style



* fix style



* fix style



* add image



* fix typo



* fix plot



* fix plot



* change plot size



* fix style



* move image



* add reset_lr to intro page



---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: mikolajblaz <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimapihtar dimapihtar dimapihtar approved these changes

Assignees

@mikolajblaz mikolajblaz

Labels
Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikolajblaz @dimapihtar