Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MM Dataprep Tutorial #8373

Closed
wants to merge 0 commits into from

Conversation

cuichenx
Copy link
Collaborator

@cuichenx cuichenx commented Feb 8, 2024

What does this PR do ?

Update Multimodal data preparation tutorial.

Collection: Multimodal

Changelog

  • Delete duplicate section
  • Populate "TODO" links with actual links from toolkit doc and launcher.

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@cuichenx cuichenx changed the base branch from main to r1.23.0 February 13, 2024 15:03
@cuichenx cuichenx changed the base branch from r1.23.0 to main February 13, 2024 15:07
@cuichenx cuichenx changed the base branch from main to r1.23.0 February 13, 2024 16:43
@cuichenx cuichenx force-pushed the chcui/update_mm_dataprep_tutorial branch from ba1f57a to d4aae2b Compare February 13, 2024 16:53
@github-actions github-actions bot added core Changes to NeMo Core TTS ASR NLP labels Feb 13, 2024
@cuichenx cuichenx closed this Feb 13, 2024
@cuichenx cuichenx force-pushed the chcui/update_mm_dataprep_tutorial branch from d4aae2b to 0f7b49b Compare February 13, 2024 17:00
@cuichenx cuichenx deleted the chcui/update_mm_dataprep_tutorial branch February 13, 2024 17:01
@cuichenx
Copy link
Collaborator Author

opened new PR here #8410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR core Changes to NeMo Core NLP TTS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant