Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reqs #8072

Merged
merged 2 commits into from
Dec 21, 2023
Merged

update reqs #8072

merged 2 commits into from
Dec 21, 2023

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Update requirements

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: eharper <[email protected]>
@github-actions github-actions bot added the CI label Dec 20, 2023
Signed-off-by: eharper <[email protected]>
@ericharper
Copy link
Collaborator Author

jenkins

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@ericharper ericharper merged commit 426c987 into r1.22.0 Dec 21, 2023
13 checks passed
@ericharper ericharper deleted the update_req branch December 21, 2023 07:04
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
* update reqs

Signed-off-by: eharper <[email protected]>

* update transformers

Signed-off-by: eharper <[email protected]>

---------

Signed-off-by: eharper <[email protected]>
nithinraok pushed a commit that referenced this pull request Dec 23, 2023
* update reqs



* update transformers



---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* update reqs

* update transformers

---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* update reqs



* update transformers



---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* update reqs



* update transformers



---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants